diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2026-07-07 18:00:32 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-07-07 20:03:02 -0700 |
| commit | 59d104b54b0b42e30fd2a68d24ee5c49dcc54d1e (patch) | |
| tree | 8755f519014ee56b65197692eb266428f4a6df77 | |
| parent | ff0c5c53d08274e200b48a4d53aa078265e873cb (diff) | |
hwmon: (nzxt-smart2) Stop device IO before calling hid_hw_stop
Calling hid_hw_stop() does not stop the device IO.
This results in a race condition between hid_input_report() and the point
immediately following the execution of hid_device_io_start() within
the driver probe function. If the probe operation fails after "io start"
has been initiated, this race condition will result in a UAF vulnerability.
Fix the problem by calling hid_device_io_stop() before calling
hid_hw_stop().
Reported-by: Sashiko <sashiko-bot@kernel.org>
Fixes: 53e68c20aeb1e ("hwmon: add driver for NZXT RGB&Fan Controller/Smart Device v2")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/nzxt-smart2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c index 58ef9fa0184b..e2316c46629d 100644 --- a/drivers/hwmon/nzxt-smart2.c +++ b/drivers/hwmon/nzxt-smart2.c @@ -768,7 +768,7 @@ static int nzxt_smart2_hid_probe(struct hid_device *hdev, out_hw_close: hid_hw_close(hdev); - + hid_device_io_stop(hdev); out_hw_stop: hid_hw_stop(hdev); return ret; |