diff options
| author | Umang Jain <umang.jain@ideasonboard.com> | 2023-10-18 11:22:28 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-21 11:55:23 +0200 |
| commit | 75fd2810b08a4854af3928121a301e50376288d2 (patch) | |
| tree | 8dcddd4c1bbfb9d06dceff4304b5e31b11d83098 | |
| parent | 875be090928d19ff4ae7cbaadb54707abb3befdf (diff) | |
staging: vc04_services: vchiq_bus: Do not kfree device
As per device_register() documentation, this kfree() on error path will
crash. The call to put_device() is all that is needed here to free the
memory.
Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/20231018055228.825524-1-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c index 4ac3491efe45..0076d091b9b2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c @@ -73,7 +73,6 @@ vchiq_device_register(struct device *parent, const char *name) if (ret) { dev_err(parent, "Cannot register %s: %d\n", name, ret); put_device(&device->dev); - kfree(device); return NULL; } |