diff options
| author | Patrick Steinhardt <ps@pks.im> | 2026-08-05 09:44:46 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-08-05 09:42:50 -0700 |
| commit | 726782254239706bc91276537450b7a21b81f99e (patch) | |
| tree | 7bf48e1a4eb49c494468f1449feef78e4ac058d8 /t/t4013/diff.diff_initial..side | |
| parent | b1b008fa2b3c7591ad0094e45fd6fc9b8fac5bff (diff) | |
odb/streaming: drop `is_finished` field
The `is_finished` field is used to track whether a write stream is done
writing all of its data. Tracking this field as part of the stream
itself shouldn't be required though: callers will already know when the
stream is done when the stream's read function returns zero bytes, same
as when reading from a file descriptor.
There is one exception where it gets a bit more complicated: when
consuming data in "builtin/unpack-objects.c" it may happen that we don't
yield any new bytes after reading from the pipe. This is addressed by
looping until we have produced at least a single byte of output.
Drop the field from `struct odb_write_stream`. Again, same as in the
preceding commit, this brings the structure a bit closer to its sibling
`struct odb_read_stream`.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.diff_initial..side')
0 files changed, 0 insertions, 0 deletions
