diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2026-06-27 17:17:56 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-06-28 08:30:21 -0700 |
| commit | f6c8bae5cdba1836d76e7eed3b41547d49869f06 (patch) | |
| tree | cce4b2bc46a46b40147ede1f7182b5f3a7cce5c0 /gitweb | |
| parent | 663d7abe07ea376c2657019a03297ae87037c993 (diff) | |
http: accept https:// proxies again
Since 663d7abe07ea (http: reject unsupported proxy URL schemes,
2026-05-05), set_curl_proxy_type() returns 0 only for the "http"
and SOCKS variants via dedicated early returns, and -1 for
everything else. The "https" branch configures the CURL handle for
HTTPS proxying but then falls through to the trailing `return -1`
intended for unknown schemes, so the caller in get_curl_handle()
treats a perfectly valid https:// proxy URL as unsupported and
refuses to use it.
Noticed while looking into a Coverity report against the same
function; the unchecked curl_easy_setopt() return values it flags
are orthogonal to this fix.
Assisted-by: Opus 4.7
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitweb')
0 files changed, 0 insertions, 0 deletions
