1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
|
// SPDX-License-Identifier: GPL-2.0
/*
* Kunit test for drm_bridge functions
*/
#include <linux/cleanup.h>
#include <linux/media-bus-format.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_atomic_state_helper.h>
#include <drm/drm_atomic_uapi.h>
#include <drm/drm_bridge.h>
#include <drm/drm_bridge_connector.h>
#include <drm/drm_bridge_helper.h>
#include <drm/drm_edid.h>
#include <drm/drm_kunit_helpers.h>
#include <drm/drm_managed.h>
#include <kunit/device.h>
#include <kunit/test.h>
#include "drm_kunit_edid.h"
/*
* Mimick the typical "private" struct defined by a bridge driver, which
* embeds a bridge plus other fields.
*
* Having at least one member before @bridge ensures we test non-zero
* @bridge offset.
*/
struct drm_bridge_priv {
unsigned int enable_count;
unsigned int disable_count;
struct drm_bridge bridge;
void *data;
};
struct drm_bridge_init_priv {
struct drm_device drm;
/** @dev: device, only for tests not needing a whole drm_device */
struct device *dev;
struct drm_plane *plane;
struct drm_crtc *crtc;
struct drm_encoder encoder;
struct drm_bridge_priv *test_bridge;
struct drm_connector *connector;
bool destroyed;
};
struct drm_bridge_chain_priv {
struct drm_device drm;
struct drm_encoder encoder;
struct drm_plane *plane;
struct drm_crtc *crtc;
struct drm_connector *connector;
unsigned int num_bridges;
/**
* @test_bridges: array of pointers to &struct drm_bridge_priv entries
* of which the first @num_bridges entries are valid.
*/
struct drm_bridge_priv **test_bridges;
};
static struct drm_bridge_priv *bridge_to_priv(struct drm_bridge *bridge)
{
return container_of(bridge, struct drm_bridge_priv, bridge);
}
static void drm_test_bridge_priv_destroy(struct drm_bridge *bridge)
{
struct drm_bridge_priv *bridge_priv = bridge_to_priv(bridge);
struct drm_bridge_init_priv *priv = (struct drm_bridge_init_priv *)bridge_priv->data;
priv->destroyed = true;
}
static void drm_test_bridge_atomic_enable(struct drm_bridge *bridge,
struct drm_atomic_commit *state)
{
struct drm_bridge_priv *priv = bridge_to_priv(bridge);
priv->enable_count++;
}
static void drm_test_bridge_atomic_disable(struct drm_bridge *bridge,
struct drm_atomic_commit *state)
{
struct drm_bridge_priv *priv = bridge_to_priv(bridge);
priv->disable_count++;
}
static const struct drm_bridge_funcs drm_test_bridge_atomic_funcs = {
.destroy = drm_test_bridge_priv_destroy,
.atomic_enable = drm_test_bridge_atomic_enable,
.atomic_disable = drm_test_bridge_atomic_disable,
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
.atomic_create_state = drm_atomic_helper_bridge_create_state,
};
static int dummy_clear_infoframe(struct drm_bridge *bridge)
{
return 0;
}
static int dummy_write_infoframe(struct drm_bridge *bridge, const u8 *buffer,
size_t len)
{
return 0;
}
static const struct drm_bridge_funcs drm_test_bridge_bus_fmts_funcs = {
.atomic_get_output_bus_fmts = drm_atomic_helper_bridge_get_hdmi_output_bus_fmts,
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
.atomic_create_state = drm_atomic_helper_bridge_create_state,
.hdmi_write_avi_infoframe = dummy_write_infoframe,
.hdmi_write_hdmi_infoframe = dummy_write_infoframe,
.hdmi_clear_avi_infoframe = dummy_clear_infoframe,
.hdmi_clear_hdmi_infoframe = dummy_clear_infoframe,
};
/**
* struct fmt_tuple - a tuple of input/output MEDIA_BUS_FMT_*
*/
struct fmt_tuple {
u32 in_fmt;
u32 out_fmt;
};
/*
* Format mapping that only accepts RGB888, and outputs only RGB888
*/
static const struct fmt_tuple rgb8_passthrough[] = {
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
};
/*
* Format mapping that only accepts YUV444, and outputs only YUV444
*/
static const struct fmt_tuple yuv8_passthrough[] = {
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
};
/*
* Format mapping where 8bpc RGB -> 8bpc YUV444, or ID(RGB) or ID(YUV444)
*/
static const struct fmt_tuple rgb8_to_yuv8_or_id[] = {
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
};
static const struct fmt_tuple rgb8_to_id_yuv8_or_yuv8_to_yuv422_yuv420[] = {
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_UYVY8_1X16 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_UYYVYY8_0_5X24 },
};
/*
* Format mapping where 8bpc YUV444 -> 8bpc RGB, or ID(YUV444)
*/
static const struct fmt_tuple yuv8_to_rgb8_or_id[] = {
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
};
/*
* A format mapping that acts like a video processor that generates an RGB signal
*/
static const struct fmt_tuple rgb_producer[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB101010_1X30 },
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB121212_1X36 },
};
/*
* A format mapping that acts like a video processor that generates an 8-bit RGB,
* YUV444 or YUV420 signal
*/
static const struct fmt_tuple rgb_yuv444_yuv420_producer[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_UYYVYY8_0_5X24 },
};
static const struct fmt_tuple rgb8_yuv444_yuv422_passthrough[] = {
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_UYVY8_1X16 },
};
static const struct fmt_tuple yuv444_yuv422_rgb8_passthrough[] = {
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_UYVY8_1X16 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
};
static bool fmt_in_list(const u32 fmt, const u32 *out_fmts, const size_t num_fmts)
{
size_t i;
for (i = 0; i < num_fmts; i++)
if (out_fmts[i] == fmt)
return true;
return false;
}
/**
* get_tuples_out_fmts - Get unique output formats of a &struct fmt_tuple list
* @fmt_tuples: array of &struct fmt_tuple
* @num_fmt_tuples: number of entries in @fmt_tuples
* @out_fmts: target array to store the unique output bus formats
*
* Returns the number of unique output formats, i.e. the number of entries in
* @out_fmts that were populated with sensible values.
*/
static size_t get_tuples_out_fmts(const struct fmt_tuple *fmt_tuples,
const size_t num_fmt_tuples, u32 *out_fmts)
{
size_t num_unique = 0;
size_t i;
for (i = 0; i < num_fmt_tuples; i++)
if (!fmt_in_list(fmt_tuples[i].out_fmt, out_fmts, num_unique))
out_fmts[num_unique++] = fmt_tuples[i].out_fmt;
return num_unique;
}
#define DEFINE_FMT_FUNCS_FROM_TUPLES(name) \
static u32 *drm_test_bridge_ ## name ## _out_fmts(struct drm_bridge *bridge, \
struct drm_bridge_state *bridge_state, \
struct drm_crtc_state *crtc_state, \
struct drm_connector_state *conn_state, \
unsigned int *num_output_fmts) \
{ \
u32 *out_fmts = kcalloc(ARRAY_SIZE((name)), sizeof(u32), GFP_KERNEL); \
\
if (out_fmts) \
*num_output_fmts = get_tuples_out_fmts((name), ARRAY_SIZE((name)), out_fmts); \
else \
*num_output_fmts = 0; \
\
return out_fmts; \
} \
\
static u32 *drm_test_bridge_ ## name ## _in_fmts(struct drm_bridge *bridge, \
struct drm_bridge_state *bridge_state, \
struct drm_crtc_state *crtc_state, \
struct drm_connector_state *conn_state, \
u32 output_fmt, \
unsigned int *num_input_fmts) \
{ \
u32 *in_fmts = kcalloc(ARRAY_SIZE((name)), sizeof(u32), GFP_KERNEL); \
unsigned int num_fmts = 0; \
size_t i; \
\
if (!in_fmts) { \
*num_input_fmts = 0; \
return NULL; \
} \
\
for (i = 0; i < ARRAY_SIZE((name)); i++) \
if ((name)[i].out_fmt == output_fmt) \
in_fmts[num_fmts++] = (name)[i].in_fmt; \
\
*num_input_fmts = num_fmts; \
\
return in_fmts; \
}
#define DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_HDMI_FUNC(ident, input_fmts_func, output_fmts_func, \
hdmi_write_infoframe_func, \
hdmi_clear_infoframe_func) \
static const struct drm_bridge_funcs (ident) = { \
.atomic_enable = drm_test_bridge_atomic_enable, \
.atomic_disable = drm_test_bridge_atomic_disable, \
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, \
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, \
.atomic_create_state = drm_atomic_helper_bridge_create_state, \
.atomic_get_input_bus_fmts = (input_fmts_func), \
.atomic_get_output_bus_fmts = (output_fmts_func), \
.hdmi_write_avi_infoframe = (hdmi_write_infoframe_func), \
.hdmi_clear_avi_infoframe = (hdmi_clear_infoframe_func), \
.hdmi_write_hdmi_infoframe = (hdmi_write_infoframe_func), \
.hdmi_clear_hdmi_infoframe = (hdmi_clear_infoframe_func), \
}
#define DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_FUNC(ident, input_fmts_func, output_fmts_func) \
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_HDMI_FUNC(ident, input_fmts_func, output_fmts_func, \
NULL, NULL)
#define DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(_name) \
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_FUNC(_name ## _funcs, \
drm_test_bridge_ ## _name ## _in_fmts, \
drm_test_bridge_ ## _name ## _out_fmts)
static int drm_test_bridge_write_infoframe_stub(struct drm_bridge *bridge,
const u8 *buffer, size_t len)
{
return 0;
}
static int drm_test_bridge_clear_infoframe_stub(struct drm_bridge *bridge)
{
return 0;
}
#define DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_HDMI(_name) \
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_HDMI_FUNC(_name ## _hdmi ## _funcs, \
drm_test_bridge_ ## _name ## _in_fmts, \
drm_test_bridge_ ## _name ## _out_fmts, \
drm_test_bridge_write_infoframe_stub, \
drm_test_bridge_clear_infoframe_stub)
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb8_passthrough)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb8_passthrough);
DEFINE_FMT_FUNCS_FROM_TUPLES(yuv8_passthrough)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(yuv8_passthrough);
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb8_to_yuv8_or_id)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb8_to_yuv8_or_id);
DEFINE_FMT_FUNCS_FROM_TUPLES(yuv8_to_rgb8_or_id)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(yuv8_to_rgb8_or_id);
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb_producer)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb_producer);
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb_yuv444_yuv420_producer)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb_yuv444_yuv420_producer);
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb8_to_id_yuv8_or_yuv8_to_yuv422_yuv420)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb8_to_id_yuv8_or_yuv8_to_yuv422_yuv420);
DEFINE_FMT_FUNCS_FROM_TUPLES(rgb8_yuv444_yuv422_passthrough)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(rgb8_yuv444_yuv422_passthrough);
DEFINE_FMT_FUNCS_FROM_TUPLES(yuv444_yuv422_rgb8_passthrough)
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT(yuv444_yuv422_rgb8_passthrough);
DRM_BRIDGE_ATOMIC_WITH_BUS_FMT_HDMI(yuv444_yuv422_rgb8_passthrough);
KUNIT_DEFINE_ACTION_WRAPPER(drm_bridge_remove_wrapper,
drm_bridge_remove,
struct drm_bridge *);
static int drm_kunit_bridge_add(struct kunit *test,
struct drm_bridge *bridge)
{
drm_bridge_add(bridge);
return kunit_add_action_or_reset(test,
drm_bridge_remove_wrapper,
bridge);
}
static struct drm_bridge_init_priv *
drm_test_bridge_init(struct kunit *test, const struct drm_bridge_funcs *funcs)
{
struct drm_bridge_init_priv *priv;
struct drm_encoder *enc;
struct drm_bridge *bridge;
struct drm_device *drm;
struct device *dev;
int ret;
dev = drm_kunit_helper_alloc_device(test);
if (IS_ERR(dev))
return ERR_CAST(dev);
priv = drm_kunit_helper_alloc_drm_device(test, dev,
struct drm_bridge_init_priv, drm,
DRIVER_MODESET | DRIVER_ATOMIC);
if (IS_ERR(priv))
return ERR_CAST(priv);
priv->test_bridge = devm_drm_bridge_alloc(dev, struct drm_bridge_priv, bridge, funcs);
if (IS_ERR(priv->test_bridge))
return ERR_CAST(priv->test_bridge);
priv->test_bridge->data = priv;
drm = &priv->drm;
priv->plane = drm_kunit_helper_create_primary_plane(test, drm,
NULL,
NULL,
NULL, 0,
NULL);
if (IS_ERR(priv->plane))
return ERR_CAST(priv->plane);
priv->crtc = drm_kunit_helper_create_crtc(test, drm,
priv->plane, NULL,
NULL,
NULL);
if (IS_ERR(priv->crtc))
return ERR_CAST(priv->crtc);
enc = &priv->encoder;
ret = drmm_encoder_init(drm, enc, NULL, DRM_MODE_ENCODER_TMDS, NULL);
if (ret)
return ERR_PTR(ret);
enc->possible_crtcs = drm_crtc_mask(priv->crtc);
bridge = &priv->test_bridge->bridge;
bridge->type = DRM_MODE_CONNECTOR_VIRTUAL;
ret = drm_kunit_bridge_add(test, bridge);
if (ret)
return ERR_PTR(ret);
ret = drm_bridge_attach(enc, bridge, NULL, 0);
if (ret)
return ERR_PTR(ret);
priv->connector = drm_bridge_connector_init(drm, enc);
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
drm_mode_config_reset(drm);
return priv;
}
static struct drm_bridge_chain_priv *
drm_test_bridge_chain_init(struct kunit *test, unsigned int num_bridges,
const struct drm_bridge_funcs **funcs)
{
struct drm_bridge_chain_priv *priv;
const struct drm_edid *edid;
struct drm_bridge *prev;
struct drm_encoder *enc;
struct drm_bridge *bridge;
struct drm_device *drm;
bool has_hdmi = false;
struct device *dev;
unsigned int i;
int ret;
dev = drm_kunit_helper_alloc_device(test);
if (IS_ERR(dev))
return ERR_CAST(dev);
priv = drm_kunit_helper_alloc_drm_device(test, dev, struct drm_bridge_chain_priv,
drm, DRIVER_MODESET | DRIVER_ATOMIC);
if (IS_ERR(priv))
return ERR_CAST(priv);
drm = &priv->drm;
priv->test_bridges = drmm_kmalloc_array(drm, num_bridges, sizeof(*priv->test_bridges),
GFP_KERNEL);
if (!priv->test_bridges)
return ERR_PTR(-ENOMEM);
priv->num_bridges = num_bridges;
for (i = 0; i < num_bridges; i++) {
priv->test_bridges[i] = devm_drm_bridge_alloc(dev, struct drm_bridge_priv,
bridge, funcs[i]);
if (IS_ERR(priv->test_bridges[i]))
return ERR_CAST(priv->test_bridges[i]);
priv->test_bridges[i]->data = priv;
}
priv->plane = drm_kunit_helper_create_primary_plane(test, drm, NULL, NULL,
NULL, 0, NULL);
if (IS_ERR(priv->plane))
return ERR_CAST(priv->plane);
priv->crtc = drm_kunit_helper_create_crtc(test, drm, priv->plane, NULL,
NULL, NULL);
if (IS_ERR(priv->crtc))
return ERR_CAST(priv->crtc);
enc = &priv->encoder;
ret = drmm_encoder_init(drm, enc, NULL, DRM_MODE_ENCODER_TMDS, NULL);
if (ret)
return ERR_PTR(ret);
enc->possible_crtcs = drm_crtc_mask(priv->crtc);
prev = NULL;
for (i = 0; i < num_bridges; i++) {
bridge = &priv->test_bridges[i]->bridge;
bridge->type = DRM_MODE_CONNECTOR_VIRTUAL;
if (bridge->funcs->hdmi_write_hdmi_infoframe) {
has_hdmi = true;
bridge->ops |= DRM_BRIDGE_OP_HDMI;
bridge->type = DRM_MODE_CONNECTOR_HDMIA;
bridge->vendor = "LNX";
bridge->product = "KUnit";
bridge->supported_formats = (BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444) |
BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444) |
BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR422) |
BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420));
}
ret = drm_kunit_bridge_add(test, bridge);
if (ret)
return ERR_PTR(ret);
ret = drm_bridge_attach(enc, bridge, prev, 0);
if (ret)
return ERR_PTR(ret);
prev = bridge;
}
priv->connector = drm_bridge_connector_init(drm, enc);
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
drm_connector_attach_encoder(priv->connector, enc);
drm_mode_config_reset(drm);
if (!has_hdmi)
return priv;
scoped_guard(mutex, &drm->mode_config.mutex) {
edid = drm_edid_alloc(test_edid_hdmi_1080p_rgb_yuv_4k_yuv420_dc_max_200mhz,
ARRAY_SIZE(test_edid_hdmi_1080p_rgb_yuv_4k_yuv420_dc_max_200mhz));
if (!edid)
return ERR_PTR(-EINVAL);
drm_edid_connector_update(priv->connector, edid);
KUNIT_ASSERT_GT(test, drm_edid_connector_add_modes(priv->connector), 0);
ret = priv->connector->funcs->fill_modes(priv->connector, 4096, 4096);
}
return priv;
}
static struct drm_bridge_init_priv *
drm_test_bridge_hdmi_init(struct kunit *test, const struct drm_bridge_funcs *funcs,
unsigned int supported_formats, int max_bpc)
{
struct drm_bridge_init_priv *priv;
struct drm_encoder *enc;
struct drm_bridge *bridge;
struct drm_device *drm;
struct device *dev;
int ret;
dev = drm_kunit_helper_alloc_device(test);
if (IS_ERR(dev))
return ERR_CAST(dev);
priv = drm_kunit_helper_alloc_drm_device(test, dev,
struct drm_bridge_init_priv, drm,
DRIVER_MODESET | DRIVER_ATOMIC);
if (IS_ERR(priv))
return ERR_CAST(priv);
priv->test_bridge = devm_drm_bridge_alloc(dev, struct drm_bridge_priv, bridge, funcs);
if (IS_ERR(priv->test_bridge))
return ERR_CAST(priv->test_bridge);
priv->test_bridge->data = priv;
drm = &priv->drm;
priv->plane = drm_kunit_helper_create_primary_plane(test, drm,
NULL,
NULL,
NULL, 0,
NULL);
if (IS_ERR(priv->plane))
return ERR_CAST(priv->plane);
priv->crtc = drm_kunit_helper_create_crtc(test, drm,
priv->plane, NULL,
NULL,
NULL);
if (IS_ERR(priv->crtc))
return ERR_CAST(priv->crtc);
enc = &priv->encoder;
ret = drmm_encoder_init(drm, enc, NULL, DRM_MODE_ENCODER_TMDS, NULL);
if (ret)
return ERR_PTR(ret);
enc->possible_crtcs = drm_crtc_mask(priv->crtc);
bridge = &priv->test_bridge->bridge;
bridge->type = DRM_MODE_CONNECTOR_HDMIA;
bridge->supported_formats = supported_formats;
bridge->max_bpc = max_bpc;
bridge->ops |= DRM_BRIDGE_OP_HDMI;
bridge->vendor = "LNX";
bridge->product = "KUnit";
ret = drm_kunit_bridge_add(test, bridge);
if (ret)
return ERR_PTR(ret);
ret = drm_bridge_attach(enc, bridge, NULL, 0);
if (ret)
return ERR_PTR(ret);
priv->connector = drm_bridge_connector_init(drm, enc);
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
drm_connector_attach_encoder(priv->connector, enc);
drm_mode_config_reset(drm);
return priv;
}
/*
* Test that drm_bridge_get_current_state() returns the last committed
* state for an atomic bridge.
*/
static void drm_test_drm_bridge_get_current_state_atomic(struct kunit *test)
{
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_init_priv *priv;
struct drm_bridge_state *curr_bridge_state;
struct drm_bridge_state *bridge_state;
struct drm_atomic_commit *state;
struct drm_bridge *bridge;
struct drm_device *drm;
int ret;
priv = drm_test_bridge_init(test, &drm_test_bridge_atomic_funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
drm = &priv->drm;
state = drm_kunit_helper_atomic_state_alloc(test, drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
bridge = &priv->test_bridge->bridge;
bridge_state = drm_atomic_get_bridge_state(state, bridge);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, bridge_state);
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_atomic_commit_clear(state);
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
drm_modeset_acquire_init(&ctx, 0);
retry_state:
ret = drm_modeset_lock(&bridge->base.lock, &ctx);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_state;
}
curr_bridge_state = drm_bridge_get_current_state(bridge);
KUNIT_EXPECT_PTR_EQ(test, curr_bridge_state, bridge_state);
drm_modeset_unlock(&bridge->base.lock);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
static struct kunit_case drm_bridge_get_current_state_tests[] = {
KUNIT_CASE(drm_test_drm_bridge_get_current_state_atomic),
{ }
};
static struct kunit_suite drm_bridge_get_current_state_test_suite = {
.name = "drm_test_bridge_get_current_state",
.test_cases = drm_bridge_get_current_state_tests,
};
/*
* Test that an atomic bridge is properly power-cycled when calling
* drm_bridge_helper_reset_crtc().
*/
static void drm_test_drm_bridge_helper_reset_crtc_atomic(struct kunit *test)
{
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_init_priv *priv;
struct drm_display_mode *mode;
struct drm_bridge_priv *bridge_priv;
int ret;
priv = drm_test_bridge_init(test, &drm_test_bridge_atomic_funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
drm_modeset_acquire_init(&ctx, 0);
retry_commit:
ret = drm_kunit_helper_enable_crtc_connector(test,
&priv->drm, priv->crtc,
priv->connector,
mode,
&ctx);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
bridge_priv = priv->test_bridge;
KUNIT_ASSERT_EQ(test, bridge_priv->enable_count, 1);
KUNIT_ASSERT_EQ(test, bridge_priv->disable_count, 0);
drm_modeset_acquire_init(&ctx, 0);
retry_reset:
ret = drm_bridge_helper_reset_crtc(&bridge_priv->bridge, &ctx);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_reset;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
KUNIT_EXPECT_EQ(test, bridge_priv->enable_count, 2);
KUNIT_EXPECT_EQ(test, bridge_priv->disable_count, 1);
}
/*
* Test that calling drm_bridge_helper_reset_crtc() on a disabled atomic
* bridge will fail and not call the enable / disable callbacks
*/
static void drm_test_drm_bridge_helper_reset_crtc_atomic_disabled(struct kunit *test)
{
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_init_priv *priv;
struct drm_display_mode *mode;
struct drm_bridge_priv *bridge_priv;
int ret;
priv = drm_test_bridge_init(test, &drm_test_bridge_atomic_funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
bridge_priv = priv->test_bridge;
KUNIT_ASSERT_EQ(test, bridge_priv->enable_count, 0);
KUNIT_ASSERT_EQ(test, bridge_priv->disable_count, 0);
drm_modeset_acquire_init(&ctx, 0);
retry_reset:
ret = drm_bridge_helper_reset_crtc(&bridge_priv->bridge, &ctx);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_reset;
}
KUNIT_EXPECT_LT(test, ret, 0);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
KUNIT_EXPECT_EQ(test, bridge_priv->enable_count, 0);
KUNIT_EXPECT_EQ(test, bridge_priv->disable_count, 0);
}
/*
* Test that a bridge using the drm_atomic_helper_bridge_get_hdmi_output_bus_fmts()
* function for &drm_bridge_funcs.atomic_get_output_bus_fmts behaves as expected
* for an HDMI connector bridge. Does so by creating an HDMI bridge connector
* with RGB444, YCBCR444, and YCBCR420 (but not YCBCR422) as supported formats,
* sets the output depth to 8 bits per component, and then validates the returned
* list of bus formats.
*/
static void drm_test_drm_bridge_helper_hdmi_output_bus_fmts(struct kunit *test)
{
struct drm_connector_state *conn_state;
struct drm_bridge_state *bridge_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_init_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
unsigned int num_output_fmts;
struct drm_bridge *bridge;
u32 *out_bus_fmts;
int ret;
priv = drm_test_bridge_hdmi_init(test, &drm_test_bridge_bus_fmts_funcs,
BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444) |
BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444) |
BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420),
12);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
bridge = &priv->test_bridge->bridge;
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
conn_state->hdmi.output_bpc = 8;
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
bridge_state = drm_atomic_get_bridge_state(state, bridge);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, bridge_state);
out_bus_fmts = bridge->funcs->atomic_get_output_bus_fmts(
bridge, bridge_state, crtc_state, conn_state, &num_output_fmts);
KUNIT_EXPECT_NOT_NULL(test, out_bus_fmts);
KUNIT_EXPECT_EQ(test, num_output_fmts, 3);
KUNIT_EXPECT_EQ(test, out_bus_fmts[0], MEDIA_BUS_FMT_RGB888_1X24);
KUNIT_EXPECT_EQ(test, out_bus_fmts[1], MEDIA_BUS_FMT_YUV8_1X24);
KUNIT_EXPECT_EQ(test, out_bus_fmts[2], MEDIA_BUS_FMT_UYYVYY8_0_5X24);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
kfree(out_bus_fmts);
}
static struct kunit_case drm_bridge_helper_reset_crtc_tests[] = {
KUNIT_CASE(drm_test_drm_bridge_helper_reset_crtc_atomic),
KUNIT_CASE(drm_test_drm_bridge_helper_reset_crtc_atomic_disabled),
KUNIT_CASE(drm_test_drm_bridge_helper_hdmi_output_bus_fmts),
{ }
};
static struct kunit_suite drm_bridge_helper_reset_crtc_test_suite = {
.name = "drm_test_bridge_helper_reset_crtc",
.test_cases = drm_bridge_helper_reset_crtc_tests,
};
static int drm_test_bridge_alloc_init(struct kunit *test)
{
struct drm_bridge_init_priv *priv;
priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
priv->dev = kunit_device_register(test, "drm-bridge-dev");
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev);
test->priv = priv;
priv->test_bridge = devm_drm_bridge_alloc(priv->dev, struct drm_bridge_priv, bridge,
&drm_test_bridge_atomic_funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->test_bridge);
priv->test_bridge->data = priv;
KUNIT_ASSERT_FALSE(test, priv->destroyed);
return 0;
}
/*
* Test that a bridge is freed when the device is destroyed in lack of
* other drm_bridge_get/put() operations.
*/
static void drm_test_drm_bridge_alloc_basic(struct kunit *test)
{
struct drm_bridge_init_priv *priv = test->priv;
KUNIT_ASSERT_FALSE(test, priv->destroyed);
kunit_device_unregister(test, priv->dev);
KUNIT_EXPECT_TRUE(test, priv->destroyed);
}
/*
* Test that a bridge is not freed when the device is destroyed when there
* is still a reference to it, and freed when that reference is put.
*/
static void drm_test_drm_bridge_alloc_get_put(struct kunit *test)
{
struct drm_bridge_init_priv *priv = test->priv;
KUNIT_ASSERT_FALSE(test, priv->destroyed);
drm_bridge_get(&priv->test_bridge->bridge);
KUNIT_EXPECT_FALSE(test, priv->destroyed);
kunit_device_unregister(test, priv->dev);
KUNIT_EXPECT_FALSE(test, priv->destroyed);
drm_bridge_put(&priv->test_bridge->bridge);
KUNIT_EXPECT_TRUE(test, priv->destroyed);
}
static struct kunit_case drm_bridge_alloc_tests[] = {
KUNIT_CASE(drm_test_drm_bridge_alloc_basic),
KUNIT_CASE(drm_test_drm_bridge_alloc_get_put),
{ }
};
static struct kunit_suite drm_bridge_alloc_test_suite = {
.name = "drm_bridge_alloc",
.init = drm_test_bridge_alloc_init,
.test_cases = drm_bridge_alloc_tests,
};
/**
* drm_test_bridge_chain_verify_fmt - Verify bridge chain format selection
* @test: pointer to KUnit test object
* @priv: pointer to a &struct drm_bridge_chain_priv for this chain
* @expected: constant array of &struct fmt_tuple describing the expected
* input and output bus formats
* @num_expected: number of entries in @expected
*
* Runs the KUNIT_EXPECT clauses to verify the bridge chain format selection
* resulted in the expected formats. If %0 is given as a format in a
* &struct fmt_tuple, then it is understood to mean "any".
*
* Must be called with the modeset lock held.
*/
static void drm_test_bridge_chain_verify_fmt(struct kunit *test,
struct drm_bridge_chain_priv *priv,
const struct fmt_tuple *const expected,
const unsigned int num_expected)
{
struct drm_bridge_state *bstate;
unsigned int i = 0;
drm_for_each_bridge_in_chain(&priv->encoder, bridge) {
KUNIT_ASSERT_LT(test, i, num_expected);
bstate = drm_bridge_get_current_state(bridge);
if (expected[i].in_fmt)
KUNIT_EXPECT_EQ(test, bstate->input_bus_cfg.format,
expected[i].in_fmt);
if (expected[i].out_fmt)
KUNIT_EXPECT_EQ(test, bstate->output_bus_cfg.format,
expected[i].out_fmt);
i++;
}
KUNIT_ASSERT_EQ_MSG(test, i, num_expected,
"Fewer bridges (%u) than expected (%u)\n", i, num_expected);
}
/*
* Test that constructs a bridge chain in which an RGB888 producer is chained to
* two bridges that will convert from RGB to YUV and from YUV to RGB respectively.
*
* The test requests an output color_format of RGB using the color_format property,
* so to satisfy this request, the bridge chain must take a detour over YUV.
*/
static void drm_test_bridge_rgb_yuv_rgb(struct kunit *test)
{
static const struct drm_bridge_funcs *funcs[] = {
&rgb_producer_funcs,
&rgb8_to_yuv8_or_id_funcs,
&yuv8_to_rgb8_or_id_funcs,
};
static const struct fmt_tuple expected[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
};
struct drm_connector_state *conn_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_chain_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
int ret;
priv = drm_test_bridge_chain_init(test, ARRAY_SIZE(funcs), funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
conn_state->color_format = DRM_CONNECTOR_COLOR_FORMAT_RGB444;
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_test_bridge_chain_verify_fmt(test, priv, expected, ARRAY_SIZE(expected));
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
/*
* Test in which a bridge capable of producing RGB, YUV444 and YUV420 has to
* produce RGB and convert with a downstream bridge in the chain to reach the
* requested YUV444 color format, as no direct path exists between its YUV444
* and the last bridge.
*
* The rationale behind this test is to devise a scenario in which naively
* assuming any format the video processor can output, and the connector
* requests, is the right format to pick, does not work.
*/
static void drm_test_bridge_must_convert_to_yuv444(struct kunit *test)
{
static const struct drm_bridge_funcs *funcs[] = {
&rgb_yuv444_yuv420_producer_funcs,
&rgb8_passthrough_funcs,
&rgb8_to_id_yuv8_or_yuv8_to_yuv422_yuv420_funcs,
&rgb8_yuv444_yuv422_passthrough_funcs,
};
static const struct fmt_tuple expected[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
};
struct drm_connector_state *conn_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_chain_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
int ret;
priv = drm_test_bridge_chain_init(test, ARRAY_SIZE(funcs), funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
conn_state->color_format = DRM_CONNECTOR_COLOR_FORMAT_YCBCR444;
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_test_bridge_chain_verify_fmt(test, priv, expected, ARRAY_SIZE(expected));
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
/*
* Test which checks that no matter the order of bus formats returned by an
* HDMI bridge, RGB is preferred on DRM_CONNECTOR_COLOR_FORMAT_AUTO if it's
* available.
*/
static void drm_test_bridge_hdmi_auto_rgb(struct kunit *test)
{
static const struct drm_bridge_funcs *funcs[] = {
&rgb_yuv444_yuv420_producer_funcs,
&yuv444_yuv422_rgb8_passthrough_hdmi_funcs,
};
static const struct fmt_tuple expected[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_RGB888_1X24 },
{ MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_1X24 },
};
struct drm_connector_state *conn_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_chain_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
int ret;
priv = drm_test_bridge_chain_init(test, ARRAY_SIZE(funcs), funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
KUNIT_ASSERT_EQ(test, conn_state->color_format, DRM_CONNECTOR_COLOR_FORMAT_AUTO);
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, conn_state->hdmi.output_format, DRM_OUTPUT_COLOR_FORMAT_RGB444);
drm_test_bridge_chain_verify_fmt(test, priv, expected, ARRAY_SIZE(expected));
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
/*
* Test which checks that DRM_CONNECTOR_COLOR_FORMAT_AUTO on non-HDMI connectors
* will result in the first bus format on the output to be picked.
*/
static void drm_test_bridge_auto_first(struct kunit *test)
{
static const struct drm_bridge_funcs *funcs[] = {
&rgb_yuv444_yuv420_producer_funcs,
&yuv444_yuv422_rgb8_passthrough_funcs,
};
static const struct fmt_tuple expected[] = {
{ MEDIA_BUS_FMT_FIXED, MEDIA_BUS_FMT_YUV8_1X24 },
{ MEDIA_BUS_FMT_YUV8_1X24, MEDIA_BUS_FMT_YUV8_1X24 },
};
struct drm_connector_state *conn_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_chain_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
int ret;
priv = drm_test_bridge_chain_init(test, ARRAY_SIZE(funcs), funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
KUNIT_ASSERT_EQ(test, conn_state->color_format, DRM_CONNECTOR_COLOR_FORMAT_AUTO);
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
drm_test_bridge_chain_verify_fmt(test, priv, expected, ARRAY_SIZE(expected));
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
/*
* Test which checks that in a configuration of bridge chains where an RGB
* producer is hooked to a YUV444-only pass-through, the atomic commit fails as
* the bridge format selection cannot find a valid sequence of bus formats.
*/
static void drm_test_bridge_rgb_yuv_no_path(struct kunit *test)
{
static const struct drm_bridge_funcs *funcs[] = {
&rgb_producer_funcs,
&yuv8_passthrough_funcs,
&rgb8_yuv444_yuv422_passthrough_funcs,
};
struct drm_connector_state *conn_state;
struct drm_modeset_acquire_ctx ctx;
struct drm_bridge_chain_priv *priv;
struct drm_crtc_state *crtc_state;
struct drm_atomic_commit *state;
struct drm_display_mode *mode;
int ret;
priv = drm_test_bridge_chain_init(test, ARRAY_SIZE(funcs), funcs);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
drm_modeset_acquire_init(&ctx, 0);
state = drm_kunit_helper_atomic_state_alloc(test, &priv->drm, &ctx);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
retry_commit:
conn_state = drm_atomic_get_connector_state(state, priv->connector);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
ret = drm_atomic_set_crtc_for_connector(conn_state, priv->crtc);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
ret = drm_atomic_set_mode_for_crtc(crtc_state, mode);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_ASSERT_EQ(test, ret, 0);
crtc_state->enable = true;
crtc_state->active = true;
ret = drm_atomic_commit(state);
if (ret == -EDEADLK) {
drm_modeset_backoff(&ctx);
goto retry_commit;
}
KUNIT_EXPECT_EQ(test, ret, -ENOTSUPP);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}
static struct kunit_case drm_bridge_bus_fmt_tests[] = {
KUNIT_CASE(drm_test_bridge_rgb_yuv_rgb),
KUNIT_CASE(drm_test_bridge_must_convert_to_yuv444),
KUNIT_CASE(drm_test_bridge_hdmi_auto_rgb),
KUNIT_CASE(drm_test_bridge_auto_first),
KUNIT_CASE(drm_test_bridge_rgb_yuv_no_path),
{ }
};
static struct kunit_suite drm_bridge_bus_fmt_test_suite = {
.name = "drm_bridge_bus_fmt",
.test_cases = drm_bridge_bus_fmt_tests,
};
kunit_test_suites(
&drm_bridge_get_current_state_test_suite,
&drm_bridge_helper_reset_crtc_test_suite,
&drm_bridge_alloc_test_suite,
&drm_bridge_bus_fmt_test_suite,
);
MODULE_AUTHOR("Maxime Ripard <mripard@kernel.org>");
MODULE_AUTHOR("Luca Ceresoli <luca.ceresoli@bootlin.com>");
MODULE_AUTHOR("Nicolas Frattaroli <nicolas.frattaroli@collabora.com>");
MODULE_DESCRIPTION("Kunit test for drm_bridge functions");
MODULE_LICENSE("GPL");
|