diff options
| author | Karl Mehltretter <kmehltretter@gmail.com> | 2026-08-27 14:42:54 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-08-31 09:54:37 +0200 |
| commit | f18e8774f4d3137fa0a5fb8ffa83d59a719666d8 (patch) | |
| tree | bac46cc6302aa5b66ea53cfcc4029bb331554a58 /tools/lib/python/kdoc/python_version.py | |
| parent | b12e20c6ac156a307acdf0545432eb3b6cb41f8f (diff) | |
netfs: Fix uninitialized return value in netfs_unbuffered_write()
If preparation of the first subrequest fails,
netfs_unbuffered_write() exits its loop before ret is initialized. The
empty-iterator check can do the same.
For synchronous writes, netfs_unbuffered_write_iter_locked() may then
return an unrelated error instead of wreq->error. This is reachable
through CIFS if cifs_prepare_write() fails to reopen the file or obtain
credits.
Initialize ret to 0 so the caller returns wreq->error if no data was
written, or the number of bytes already written otherwise.
Found with Clang's -Wconditional-uninitialized.
Fixes: a0b4c7a49137e ("netfs: Fix unbuffered/DIO writes to dispatch subrequests in strict sequence")
Cc: stable@vger.kernel.org
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://patch.msgid.link/20260827134304.2075713-2-dhowells@redhat.com
Acked-by: Paulo Alcantara <pc@manguebit.org>
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Diffstat (limited to 'tools/lib/python/kdoc/python_version.py')
0 files changed, 0 insertions, 0 deletions
